-
Notifications
You must be signed in to change notification settings - Fork 795
[UR][L0] urBindlessImagesGetImageMemoryHandleTypeSupportExp correction #19667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+12
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrspruit
approved these changes
Jul 31, 2025
Contributor
nrspruit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
a66165e to
afebeb5
Compare
d558aad to
f9cf01c
Compare
3eaf604 to
73acb35
Compare
7b1d40c to
bef3fea
Compare
efe8feb to
c976b78
Compare
nrspruit
approved these changes
Aug 19, 2025
VK_FORMAT_R8G8B8A8_UNORM is supported on L0 urt, correction to verifyCommonImagePropertiesSupport. Signed-off-by: Zhang, Winston <[email protected]>
Signed-off-by: Zhang, Winston <[email protected]>
Signed-off-by: Zhang, Winston <[email protected]>
c976b78 to
28b887d
Compare
Contributor
|
@intel/llvm-gatekeepers , please merge when able. |
AlexeySachkov
pushed a commit
to AlexeySachkov/llvm
that referenced
this pull request
Sep 10, 2025
intel#19667) VK_FORMAT_R8G8B8A8_UNORM is supported on L0 urt, correction to verifyCommonImagePropertiesSupport. --------- Signed-off-by: Zhang, Winston <[email protected]>
AlexeySachkov
added a commit
that referenced
this pull request
Sep 23, 2025
This is a joined cherry-pick of: --- [UR][L0] Remove Driver Exp Implementation of External Semaphore (#19835) - Intel L0 GPU Driver no longer supports the Driver Exp Implementation of External Semaphore and the code has been removed from the codebase, therefore the support needs to be removed from the adapter to allow compiling with newer ze_intel_gpu.h headers. - L0 Spec implementation is the only version required for customer support. Patch-by: Neil R. Spruit <[email protected]> --- [UR][L0] urBindlessImagesGetImageMemoryHandleTypeSupportExp correction (#19667) VK_FORMAT_R8G8B8A8_UNORM is supported on L0 urt, correction to verifyCommonImagePropertiesSupport. Patch-by: Zhang, Winston <[email protected]> --- [UR][L0][V2] Fixed supported logic for external semaphore (#19863) Patch-by: Neil R. Spruit <[email protected]> --- [UR][L0] Fix Implict Event sync during external semaphore wait/signal (#19859) - When SYCl Calls the L0 adapter without a signal event, L0 creates an internal event. - Given in order command queue, the internal event for the wait/signal is implicitly added to the wait list of the next command if executeCommandList is called. - This ensures that the internal event is properly synchronized with the command queue during that next call given SYCL is failing to create a UR event for tracking the wait/signal. Patch-by: Neil R. Spruit <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VK_FORMAT_R8G8B8A8_UNORM is supported on L0 urt, correction to verifyCommonImagePropertiesSupport.